fixes #38 / Update release-build.yml #39
Conversation
Updated release-build.yml to use dotnet nuget push command.
WalkthroughThe workflow for publishing packages to NuGet in the GitHub Actions release build was updated to use the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant dotnet CLI
participant NuGet Server
GitHub Actions->>dotnet CLI: dotnet nuget push **/*.nupkg -s ... -k ...
dotnet CLI->>NuGet Server: Upload .nupkg package(s) using API key
NuGet Server-->>dotnet CLI: Response (success/failure)
dotnet CLI-->>GitHub Actions: Publish result
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(No out-of-scope changes found.) Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release-build.yml (1)
44-44: Normalize secret interpolation, quote globs, and optionally push symbolsThe current step:
run: dotnet nuget push **/*.nupkg -s 'https://api.nuget.org/v3/index.json' -k ${{secrets.ICG_NUGET_API_KEY}}can be tightened up to:
-run: dotnet nuget push **/*.nupkg -s 'https://api.nuget.org/v3/index.json' -k ${{secrets.ICG_NUGET_API_KEY}} +run: dotnet nuget push "**/*.nupkg" -s "https://api.nuget.org/v3/index.json" -k ${{ secrets.ICG_NUGET_API_KEY }}And, if you also publish symbol packages, add a second push step:
+ - name: Publish symbols to NuGet + run: dotnet nuget push "**/*.snupkg" -s "https://api.nuget.org/v3/index.json" -k ${{ secrets.ICG_NUGET_API_KEY }}
|
@AkrausGH This one is going to take a bit more updates to get current, if you want to try and tackle this it would be great. But the following is going to be needed.
Then try again, we MAY need to replace the gitversion.yml file with a modified version as well |
Changed the target frameworks for the three projects. I also updated the release-build to refer to .NET 8.0.
Trying to change the "Ensure .NET Installed" command.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci-build.yml (1)
25-25: Remove trailing whitespace
YAMLLint flags trailing spaces on this line—please remove them to clear lint errors..github/workflows/release-build.yml (1)
26-26: Remove trailing whitespace
A trailing space was detected here. Removing it will resolve the YAMLLint error.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/ci-build.yml(1 hunks).github/workflows/release-build.yml(2 hunks)src/AspNetCore.Utilities.FontAwesomeTagHelpers.Sample/AspNetCore.Utilities.FontAwesomeTagHelpers.Sample.csproj(1 hunks)src/AspNetCore.Utilities.FontAwesomeTagHelpers.Tests/AspNetCore.Utilities.FontAwesomeTagHelpers.Tests.csproj(1 hunks)src/AspNetCore.Utilities.FontAwesomeTagHelpers/AspNetCore.Utilities.FontAwesomeTagHelpers.csproj(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- src/AspNetCore.Utilities.FontAwesomeTagHelpers.Tests/AspNetCore.Utilities.FontAwesomeTagHelpers.Tests.csproj
- src/AspNetCore.Utilities.FontAwesomeTagHelpers.Sample/AspNetCore.Utilities.FontAwesomeTagHelpers.Sample.csproj
- src/AspNetCore.Utilities.FontAwesomeTagHelpers/AspNetCore.Utilities.FontAwesomeTagHelpers.csproj
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/ci-build.yml
[error] 25-25: trailing spaces
(trailing-spaces)
.github/workflows/release-build.yml
[error] 26-26: trailing spaces
(trailing-spaces)
🔇 Additional comments (5)
.github/workflows/ci-build.yml (2)
22-24: Upgrade .NET Setup Action and Target SDK
Usingactions/setup-dotnet@v4withdotnet-version: 8.0.xcorrectly aligns the CI pipeline with the .NET 8 migration.
27-27: Pin GitVersion.Tool for Consistency
Specifying--version 5.12.0ensures deterministic versioning across CI and release builds..github/workflows/release-build.yml (3)
23-25: Upgrade .NET Setup Action and Target SDK
Switching toactions/setup-dotnet@v4anddotnet-version: 8.0.xkeeps the release pipeline in sync with your .NET 8 upgrade.
28-28: Pin GitVersion.Tool for Reproducibility
Locking the tool to version 5.12.0 matches your CI config and prevents unexpected version bumps.
44-44: Switch todotnet nuget pushwith Unix-Style Globs
Replacingnuget pushwithdotnet nuget push **/*.nupkg -s … -k …ensures cross-platform compatibility and uses the official .NET CLI.
mitchelsellers
deleted the
feature/38-update-production-release-for-nuget
branch
Updated release-build.yml to use dotnet nuget push command.
Summary by CodeRabbit