Skip to content

Feature/system wide updates #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Feature/system wide updates #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01b418d
Updated downstream dependencies #56
mitchelsellers Oct 30, 2024
51452d8
Updated documentation
mitchelsellers Oct 30, 2024
8ea5344
Addressed an issue with token duration usage.
mitchelsellers Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This project provides a number of helpful wrappers around the Microsoft Azure St

## NuGet Status (ICG.AspNetCore.Utilities.CloudStorage)

![](https://img.shields.io/nuget/v/icg.aspnetcore.utilities.cloudstorage.svg) ![](https://img.shields.io/nuget/dt/icg.aspnetcore.utilities.cloudstorage.svg) |
![](https://img.shields.io/nuget/v/icg.aspnetcore.utilities.cloudstorage.svg) ![](https://img.shields.io/nuget/dt/icg.aspnetcore.utilities.cloudstorage.svg)

## SonarCloud Analysis

Expand Down Expand Up @@ -46,7 +46,11 @@ Lastly, before using you will need to configure your storage options. An exampl
}
```

NOTE: Root client path could be https://youraccount.blob.core.windows.net or if you have configured a CDN your CDN path. This is what will be used to provide the return path of uploaded objects
> [!NOTE]
> Root client path could be https://youraccount.blob.core.windows.net or if you have configured a CDN your CDN path. This is what will be used to provide the return path of uploaded objects

> [!WARNING]
> Be sure to consider security of these credentials, this library fully supports `IOptions` so you can utilize environment variables, the `appsettings.json` file or any other mechanism that injects values to Configuration

### Included Features

Expand Down
10 changes: 5 additions & 5 deletions src/AspNetCore.Utilities.CloudStorage.Tests/AspNetCore.Utilities.CloudStorage.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="3.1.2">
<PackageReference Include="coverlet.collector" Version="6.0.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
<PackageReference Include="Moq" Version="4.16.1" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
10 changes: 5 additions & 5 deletions src/AspNetCore.Utilities.CloudStorage/AspNetCore.Utilities.CloudStorage.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PackageId>ICG.AspNetCore.Utilities.CloudStorage</PackageId>
<Title>AspNetCore Utilities CloudStorage</Title>
<Description>A collection of utilities designed to aid in the storage of files to cloud storage locations.</Description>
<Copyright>Copyright 2021, IowaComputerGurus, Subject to the MIT License</Copyright>
<Copyright>Copyright 2024, IowaComputerGurus, Subject to the MIT License</Copyright>
<PackageProjectUrl>https://github.com/IowaComputerGurus/aspnetcore.utilities.cloudstorage</PackageProjectUrl>
<PackageTags>aspnetcore;azure-storage;cloudstorage</PackageTags>
<RepositoryUrl>https://github.com/IowaComputerGurus/aspnetcore.utilities.cloudstorage</RepositoryUrl>
Expand Down Expand Up @@ -37,10 +37,10 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Azure.Storage.Blobs" Version="12.10.0" />
<PackageReference Include="ICG.NetCore.Utilities" Version="6.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
<PackageReference Include="Azure.Storage.Blobs" Version="12.22.2" />
<PackageReference Include="ICG.NetCore.Utilities" Version="6.2.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion src/AspNetCore.Utilities.CloudStorage/AzureCloudStorageProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ public string CreateSASUrl(string container, string objectName, int tokenDuratio
BlobContainerName = container,
BlobName = objectName,
Resource = "b",
ExpiresOn = DateTimeOffset.UtcNow.AddHours(1)
ExpiresOn = DateTimeOffset.UtcNow.AddMinutes(tokenDuration)
};
tokenBuilder.SetPermissions(BlobSasPermissions.Read);
return blobClient.GenerateSasUri(tokenBuilder).ToString();
Expand Down