Skip to content

updated to net 8 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

updated to net 8 #53

merged 2 commits into from
Aug 21, 2024

Conversation

bradychristensen23
Copy link
Contributor

@bradychristensen23 bradychristensen23 commented Aug 20, 2024

Summary by CodeRabbit

  • New Features
    • Upgraded the target framework to .NET 8.0, enhancing performance, features, and security.
    • Updated the Microsoft.Extensions.DependencyInjection package to version 8.0.0 for improved compatibility and functionality.
  • Chores
    • Updated CI/CD pipeline configurations to utilize .NET 8.0, ensuring alignment with the latest framework standards.

Copy link

coderabbitai bot commented Aug 20, 2024

Walkthrough

The primary change in this update is the transition of the project to .NET 8, enhancing performance and access to the latest features. The Microsoft.Extensions.DependencyInjection package was also upgraded to version 8.0.0 to ensure compatibility with the new framework. These modifications aim to modernize the codebase and optimize its functionality for future development.

Changes

Files Change Summary
.../AspNetCore.Utilities.CloudStorage.Tests.csproj, .../AspNetCore.Utilities.CloudStorage.csproj, .../ci-build.yml, .../release-build.yml Updated .NET version from 6.0 to 8.0 across project files and workflows.
.../AspNetCore.Utilities.CloudStorage.csproj Updated Microsoft.Extensions.DependencyInjection package from 6.0.0 to 8.0.0.

Assessment against linked issues

Objective Addressed Explanation
Update to .NET 8 ( #50 )
Update copyright in .csproj to 2024 ( #50 ) Copyright update is not included.

🐇 In a world of code and light,
A rabbit hops with all its might.
.NET 8 is here, oh what a treat,
With new adventures, oh so sweet!
Dependencies upgraded, we leap and cheer,
For brighter paths, the future is near! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a811793 and 2272e79.

Files selected for processing (2)
  • src/AspNetCore.Utilities.CloudStorage.Tests/AspNetCore.Utilities.CloudStorage.Tests.csproj (1 hunks)
  • src/AspNetCore.Utilities.CloudStorage/AspNetCore.Utilities.CloudStorage.csproj (2 hunks)
Additional comments not posted (3)
src/AspNetCore.Utilities.CloudStorage.Tests/AspNetCore.Utilities.CloudStorage.Tests.csproj (1)

4-4: Framework update to .NET 8 approved.

The target framework has been updated to net8.0, aligning with the PR objectives. Ensure that all tests are compatible with .NET 8.

src/AspNetCore.Utilities.CloudStorage/AspNetCore.Utilities.CloudStorage.csproj (2)

42-42: Dependency update to Microsoft.Extensions.DependencyInjection version 8.0.0 approved.

The package has been updated to ensure compatibility with .NET 8. Verify that all usages of Microsoft.Extensions.DependencyInjection are compatible with version 8.0.0.

Verification successful

Verification successful for Microsoft.Extensions.DependencyInjection version 8.0.0

The usages of IServiceCollection and AddTransient in StartupExtensions.cs are compatible with version 8.0.0 of Microsoft.Extensions.DependencyInjection. No issues were found.

  • IServiceCollection usage in UseIcgAspNetCoreUtilitiesCloudStorage
  • AddTransient registrations for IMimeTypeMapper and IAzureCloudStorageProvider
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all usages of `Microsoft.Extensions.DependencyInjection` are compatible with version 8.0.0.

# Test: Search for `Microsoft.Extensions.DependencyInjection` usage.
rg --type cs 'Microsoft.Extensions.DependencyInjection'

Length of output: 186


Script:

#!/bin/bash
# Description: Search for specific usages of common methods and classes from `Microsoft.Extensions.DependencyInjection`.
rg --type cs 'AddSingleton|AddScoped|AddTransient|IServiceCollection'

Length of output: 602


22-22: Framework update to .NET 8 approved.

The target framework has been updated to net8.0, aligning with the PR objectives. Ensure that the project is compatible with .NET 8.

Verification successful

Framework update to .NET 8 verified.

The project files are set to use .NET 8, and no deprecated APIs were found in the codebase, suggesting compatibility. However, consider conducting further testing to ensure full compatibility.

  • .csproj files contain <TargetFramework>net8.0</TargetFramework>.
  • No deprecated or obsolete APIs were detected.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all project files are compatible with .NET 8.

# Test: List all project files to ensure they are compatible with .NET 8.
fd --type f --extension cs --exec cat {} \; | rg 'net8.0'

Length of output: 60


Script:

#!/bin/bash
# Find all .csproj files and check for the target framework net8.0
fd --type f --extension csproj --exec rg '<TargetFramework>net8.0</TargetFramework>' {}

# Check for any deprecated APIs or compatibility issues with .NET 8
fd --type f --extension cs --exec rg 'Obsolete|deprecated' {}

Length of output: 247

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2272e79 and b834d66.

Files selected for processing (2)
  • .github/workflows/ci-build.yml (1 hunks)
  • .github/workflows/release-build.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/release-build.yml (1)

23-23: Update to .NET 8 approved.

The update to dotnet-version: 8.0.x is aligned with the PR objectives. Ensure that all dependencies and tools used in the workflow are compatible with .NET 8.

.github/workflows/ci-build.yml (1)

24-24: Update to .NET 8 approved.

The update to dotnet-version: 8.0.x is aligned with the PR objectives. Ensure that all dependencies and tools used in the workflow are compatible with .NET 8.

Copy link

@mitchelsellers mitchelsellers merged commit 436fcc4 into develop Aug 21, 2024
3 checks passed
@mitchelsellers mitchelsellers deleted the Feature/UpdateToNet8 branch August 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to .NET 8
2 participants