feat(2D): support selective-checkpoint-offload for 2D attention #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _ckpt_block_num = int(gpc.config.model.checkpoint * gpc.config.isp_num_layers) | ||
|
|
||
| if gpc.is_forward is False and gpc.config.selective_checkpoint: | ||
| assert layer_idx in fa_output_mapping |
There was a problem hiding this comment.
第11行fa_output_mapping的初始化可以去掉了
huangting4201
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support selective-checkpoint-offload for 2D attention, which offload the attention activation to CPU when enable selective activation checkpoint.
Modification
internlm/model/ops/ring_flash_attn/zigzag_ring_flash_attn_with_sliding_window.py
Use cases (Optional)
TODO
loss testing