Skip to content

Conversation

sallyjunjun
Copy link
Collaborator

@sallyjunjun sallyjunjun commented Sep 23, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix the condition to tell rein dp.
add multimodal data processing in streaming dataset.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sallyjunjun sallyjunjun force-pushed the fix-inject branch 2 times, most recently from a225e1a to f752080 Compare September 23, 2024 10:45
@sallyjunjun sallyjunjun force-pushed the fix-inject branch 3 times, most recently from af41495 to 38e0f23 Compare September 26, 2024 02:59
@sallyjunjun sallyjunjun changed the title fix inject model fix inject model and add multimodal dataloader Sep 26, 2024
@sunpengsdu sunpengsdu merged commit d0a19fb into develop Sep 26, 2024
26 checks passed
@sallyjunjun sallyjunjun deleted the fix-inject branch March 20, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants