Skip to content

Conversation

zigzagcai
Copy link
Collaborator

@zigzagcai zigzagcai commented Sep 13, 2024

Motivation

Improve usability:

  1. Add pack_sample_into_one=True mode for streaming dataloader. (Completed)
    • For the purpose of long sequence training verification
  2. Refine model_inject_helper to support more general modeling files (such like huggingface) without even one line of code change. (Completed)
    • For easier adaption for third-party models, to demonstrate InternEvo usability
    • model_inject_helper support pipeline parallel mode
  3. Refine and optimize the implementation of MockedDataset. (Completed)
    • added sanity check to ensure global_bsz and data equivalence between loaded/saved data

Related repo:

https://github.com/InternLM/InternEvo-HFModels

Examples:

Modification

internlm/train/pipeline.py

BC-breaking (Optional)

None

Use cases (Optional)

None

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zigzagcai zigzagcai changed the title feat(usability): Refine model inject helper and megatron/mock dataloader for general usage scenarios feat(usability): Refine model inject helper Sep 13, 2024
@zigzagcai zigzagcai changed the title feat(usability): Refine model inject helper feat(usability): Refine model inject helper to support huggingface models Sep 13, 2024
@sunpengsdu sunpengsdu merged commit 569eb25 into develop Sep 20, 2024
20 checks passed
@zigzagcai zigzagcai deleted the fix-dataloader-and-inject-helper branch September 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants