Skip to content

fix(cross_entropy.py): replace the fa loss with apex loss #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 6, 2024
Merged

fix(cross_entropy.py): replace the fa loss with apex loss #317

merged 7 commits into from
Sep 6, 2024

Conversation

yingtongxiong
Copy link
Collaborator

@yingtongxiong yingtongxiong commented Sep 6, 2024 •
edited
Loading

Motivation

For the issue: #306

  1. replace the apex loss with fa loss since fa loss computation may lead to loss divergence. However, we keep the fa loss in cross_entropy.py.
  2. update readme

@sunpengsdu sunpengsdu merged commit 4452ad6 into InternLM:develop Sep 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sunpengsdu sunpengsdu sunpengsdu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZwwWayne ZwwWayne

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yingtongxiong @sunpengsdu @ZwwWayne