Skip to content

Conversation

@zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Dec 21, 2024

We should just use pull_request not pull_request_target

pull_request_target will executes code on the base commit, but not the PR commits.
pull_request_target is used for prevent secure hack, but I think we don't need worry about the hack?

Signed-off-by: Kevin Z <zyxkad@gmail.com>
@zyxkad zyxkad requested a review from SirEndii December 21, 2024 23:54
@SirEndii SirEndii merged commit d214770 into dev/1.20.1 Dec 22, 2024
6 checks passed
@zyxkad
Copy link
Collaborator Author

zyxkad commented Dec 22, 2024

well okay, I need do more research to fix that

@zyxkad zyxkad deleted the zyxkad-patch-1 branch January 10, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants