Add broadcast option to the chat box
#667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good for me. |
Not sure, tested only on 1.20.1 |
2 tasks
zyxkad
requested changes
Dec 2, 2024
.../de/srendi/advancedperipherals/common/addons/computercraft/peripheral/ChatBoxPeripheral.java
Show resolved
Hide resolved
Niki4tap
changed the title
PlayerList.broadcastSystemMessage if we canbroadcast option to the chat box
|
Rebased and config option added. @zyxkad does this implementation look ok? |
zyxkad
approved these changes
Dec 4, 2024
|
@Niki4tap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, ...)
If possible (range, max range are infinite and chat box is multidimensional), we use
broadcastSystemMessage, instead of sending one to each player.What is the current behavior? (You can also link to an open issue here)
We send a message to each player individually, no matter the config options.
What is the new behavior (if this is a feature change)?
Described above.
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
None, internal change.
Other information:
Main motivation for this change is: make the intent more clear, so mods that operate on chat (specifically tested with mc2discord, mixins only into
broadcastSystemMessage), can identify the messages and process them.