combine shared data function #13941
Merged
combine shared data function #13941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Apr 15, 2025
common/output-model.cpp
Outdated
| @@ -1204,7 +1204,7 @@ void stream_dashboard::draw_dashboard(ux_window& win, rect& r) | |||
|
|
|||
| void frame_drops_dashboard::process_frame(rs2::frame f) | |||
| { | |||
| write_shared_data([&](){ | |||
| shared_data_access::write_shared_data([&](){ | |||
There was a problem hiding this comment.
Why not rs::utils it?
With some UT maybe :)
another question can't we set the mute in the class construction and not send it on each action?
There was a problem hiding this comment.
Added under rsutils/concurrency/shared-data-access and changed the functionality to set the mutex in the class construction.
Nir-Az
reviewed
Apr 29, 2025
| // License: Apache 2.0. See LICENSE file in root directory. | ||
| // Copyright(c) 2025 Intel Corporation. All Rights Reserved. | ||
| #pragma once | ||
| #include <mutex> |
There was a problem hiding this comment.
Please add all needed includes this file use from std.
I see for example
std::function
There was a problem hiding this comment.
You're right I added it, thanks
Noy-Zini
force-pushed
the
fix-static-analysis-issue
branch
from
0d5c8c4 to
771bf0e
Compare
Nir-Az
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the
write_shared_dataandread_shared_datafunctions, which were previously used separately in both theoutput-modelandgraph-modelclass, by creating a new class that contains these functions for shared use.