Skip to content

remove unused functions #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

remove unused functions #87

merged 1 commit into from
Jul 15, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 14, 2025

The following functions are removed from backend since they are not exposed and are not part of numpy.ufuncs: invsqrt, erf, ones_like, arg.

floor_divide is only defined in the header file without any implementation, so it is removed from header file.

true_divide in numpy is internally an alias of divide. So, when numpy is patched with mkl_umath (i.e. mkl_umath.use_in_numpy()) and numpy.true_divide is called, oneMKL implementation of divide will be called.

@vtavana vtavana self-assigned this Jul 14, 2025
@vtavana vtavana marked this pull request as ready for review July 14, 2025 23:56
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, changes LGTM

@vtavana vtavana merged commit 795eb7d into main Jul 15, 2025
32 checks passed
@vtavana vtavana deleted the remove-unused-ufuncs branch July 15, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants