Skip to content

Correct dependency on numpy version in test_1d_equal_nan_axis0 #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Correct dependency on numpy version in test_1d_equal_nan_axis0 #2538

merged 1 commit into from
Jul 25, 2025
+3 −3

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 25, 2025 •
edited
Loading

The test_1d_equal_nan_axis0 test depends on a fix for numpy#29372. It was not included as part of numpy 2.3.2 release.
The PR proposes to updated the expected dependency on numpy version with the fix.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 25, 2025
@antonwolfy antonwolfy self-assigned this Jul 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_20 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy . LGTM

@antonwolfy antonwolfy merged commit add573a into master Jul 25, 2025
120 of 121 checks passed
@antonwolfy antonwolfy deleted the correct-numpy-dep-in-test_1d_equal_nan_axis0 branch July 25, 2025 17:22
github-actions bot added a commit that referenced this pull request Jul 25, 2025
@github-actions
Correct dependency on numpy version in test_1d_equal_nan_axis0 (#2538)
353a570 
The `test_1d_equal_nan_axis0` test depends on a fix for numpy#29372. It
was not included as part of numpy 2.3.2 release.
The PR proposes to updated the expected dependency on numpy version with
the fix. add573a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev