Add missing MKL function from VM namespace #2445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_15 ran successfully. |
antonwolfy
force-pushed
the
add-missing-mkl-vm-funcs
branch
from
da8eccc to
d09fbdd
Compare
antonwolfy
force-pushed
the
add-missing-mkl-vm-funcs
branch
from
d09fbdd to
869adff
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
vtavana
reviewed
May 14, 2025
vtavana
reviewed
May 14, 2025
vtavana
approved these changes
May 14, 2025
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 14, 2025
The PR add missing MKL functions from VM namespace to the dedicated extension: - `arg()` to be used by `dpnp.angle` - `copysign()` - `i0()` - `inv()` to be used by `dpnp.reciprocal` Note, `remainder()` is available as MKL VM function but follows C's module operator and so can't be used to implement `dpnp.remainder` which has to follow Python's module operator according to Python array API [specification](https://data-apis.org/array-api/2024.12/API_specification/generated/array_api.remainder.html): > This function is equivalent to the Python modulus operator x1_i % x2_i. Note, `sycl::half` is not intended to be used for VM functions due to accuracy reason and values mismatch with numpy in corner cases. acfc678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add missing MKL functions from VM namespace to the dedicated extension:
arg()to be used bydpnp.anglecopysign()i0()inv()to be used bydpnp.reciprocalNote,
remainder()is available as MKL VM function but follows C's module operator and so can't be used to implementdpnp.remainderwhich has to follow Python's module operator according to Python array API specification:Note,
sycl::halfis not intended to be used for VM functions due to accuracy reason and values mismatch with numpy in corner cases.