Move all logic with cyl_bessel_i0 support in i0.hpp
#2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
antonwolfy
force-pushed
the
expose-cyl_bessel_i0-as-part-of-i0-header
branch
2 times, most recently
from
bda573e to
b204f05
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_8 ran successfully. |
antonwolfy
force-pushed
the
expose-cyl_bessel_i0-as-part-of-i0-header
branch
from
b204f05 to
5411d71
Compare
antonwolfy
force-pushed
the
expose-cyl_bessel_i0-as-part-of-i0-header
branch
from
5411d71 to
e1ad68c
Compare
vtavana
approved these changes
May 9, 2025
vlad-perevezentsev
approved these changes
May 9, 2025
github-actions bot
added a commit
that referenced
this pull request
May 12, 2025
This PR proposes to make `cyl_bessel_i0` function fully exposed by `dpnp/backend/kernels/elementwise_functions/i0.hpp` header to hide all logic validating if `sycl::ext::intel::math::cyl_bessel_i0` function from `sycl/ext/intel/math.hpp` header can be used or native implementation is required. 9792685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to make
cyl_bessel_i0function fully exposed bydpnp/backend/kernels/elementwise_functions/i0.hppheader to hide all logic validating ifsycl::ext::intel::math::cyl_bessel_i0function fromsycl/ext/intel/math.hppheader can be used or native implementation is required.