Skip to content

Add a missing event dependency for the strided kernel of erf #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2025
Merged

Add a missing event dependency for the strided kernel of erf #2378

merged 2 commits into from
Mar 21, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 21, 2025 •
edited
Loading

The PR proposes to resolve a sporadic failure due to mismatch with the expected data in test_strides.py::test_erf.
The issue looks caused by missing dependency from strided erf kernel on a copy event (produced by copy kernel to transfer the strides of input array from host to device memory).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Mar 21, 2025
@antonwolfy antonwolfy added this to the 0.18.0 release milestone Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_39 ran successfully.
Passed: 1005
Failed: 0
Skipped: 45

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.774% (+0.001%) from 71.773%
when pulling 894dd16 on add-missing-event-dep-in-erf-kernel
into 74b5e54 on master.

@antonwolfy antonwolfy merged commit f0aa21d into master Mar 21, 2025
68 checks passed
@antonwolfy antonwolfy deleted the add-missing-event-dep-in-erf-kernel branch March 21, 2025 14:18
github-actions bot added a commit that referenced this pull request Mar 21, 2025
@github-actions
Add a missing event dependency for the strided kernel of erf (#2378)
d361f1e 
The PR proposes to resolve a sporadic failure due to mismatch with the
expected data in `test_strides.py::test_erf`.
The issue looks caused by missing dependency from strided erf kernel on
a copy event (produced by copy kernel to transfer the strides of input
array from host to device memory). f0aa21d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana