-
Notifications
You must be signed in to change notification settings - Fork 30
Fix technical debt in trig element-wise function tests #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_69 ran successfully. |
8b4f079
to
de8c3ee
Compare
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_69 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_74 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_75 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ndgrigorian!
This PR proposes removing a number of trig tests, and rewriting some
Some of these tests are redundant with other tests already present in the test suite, checking the outcome of generic parts of the element-wise function machinery (i.e., testing for identical output
usm_type
as input). Any arbitrary element-wise function could be used to check this machinery.Also removes all tests for complex special cases, as
cmath
cannot be used without creating complicated logic in the test suitereintroducing or rewriting these tests for a smaller subset of complex special cases, and for each function individually, may be a step to take in a later PR, when further refactoring the test suite