Skip to content

ENH: Consolidate JUPYTERLAB and JUPYTER_NOTEBOOK Env's into JUPYTER #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 18, 2024

With Jupyter Lab 4 / Jupyter Notebook 7, we cannot detect the difference
and there is not a difference in how we deal with them.

With Jupyter Lab 4 / Jupyter Notebook 7, we cannot detect the difference
and there is not a difference in how we deal with them.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@thewtex thewtex requested a review from bnmajor April 18, 2024 20:52
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thewtex thewtex merged commit 74cd431 into InsightSoftwareConsortium:main Apr 19, 2024
6 checks passed
@thewtex thewtex deleted the jupyter-consolidation branch April 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants