ENH: Remove imjoy-jupyterlab-extension pin for JupyterLab>=4 support #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @oeway ! |
This was referenced Apr 14, 2024
|
Looks good! However, I am not sure it will work for the jupyterlab<4, is this backward compatible? |
Good point. Probably not. And the JupyterLab docs recommend publishing a major version of the extension to go along with their breaking changes. However, since we are still alpha, and more breaking changes should be anticipated, I think we should still publish as 1.0aX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed with: imjoy-team/imjoy-jupyterlab-extension#7