Skip to content

Use Attempt<Str> as source of temporary files #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025

Conversation

Baptouuuu
Copy link
Member

This method is mainly used in innmind/amqp to create files coming from the socket. The type returned from the socket should be an Attempt<Str> hence the change.

And if someone still use Maybes they can call ->attempt() on it to make it compatible.

@Baptouuuu Baptouuuu self-assigned this May 24, 2025
@Baptouuuu Baptouuuu added the enhancement New feature or request label May 24, 2025
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (4150f6d) to head (8fbe58c).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #15      +/-   ##
=============================================
+ Coverage      91.46%   91.47%   +0.01%     
  Complexity       126      126              
=============================================
  Files             21       21              
  Lines            972      974       +2     
=============================================
+ Hits             889      891       +2     
  Misses            83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu merged commit 2234f95 into develop May 24, 2025
64 checks passed
@Baptouuuu Baptouuuu deleted the temporary-attempts branch May 24, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant