-
Notifications
You must be signed in to change notification settings - Fork 0
Remove interfaces #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14 +/- ##
==============================================
+ Coverage 72.13% 91.46% +19.32%
+ Complexity 185 126 -59
==============================================
Files 29 21 -8
Lines 1066 972 -94
==============================================
+ Hits 769 889 +120
+ Misses 297 83 -214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every API is currently behind an interface but this prevents adding new features without releasing a new major version.
To fix that it now uses closure as extension points declared on the
Config
object. And to create a new OS one need to call$os->map($configMapper)
.The 2 decorators have been replaced by
Config\Resilient
andConfig\Logger
mappers. This allows to have a better overview of what is changed with these mappers and needs less code.For the sake of simplicity some logged information has been removed has it would require to create extension points specifically for that. (But if really needed it can be added afterwards).