Skip to content

Remove interfaces #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
May 24, 2025
Merged

Remove interfaces #14

merged 41 commits into from
May 24, 2025

Conversation

Baptouuuu
Copy link
Member

@Baptouuuu Baptouuuu commented May 18, 2025

Every API is currently behind an interface but this prevents adding new features without releasing a new major version.

To fix that it now uses closure as extension points declared on the Config object. And to create a new OS one need to call $os->map($configMapper).

The 2 decorators have been replaced by Config\Resilient and Config\Logger mappers. This allows to have a better overview of what is changed with these mappers and needs less code.

For the sake of simplicity some logged information has been removed has it would require to create extension points specifically for that. (But if really needed it can be added afterwards).

@Baptouuuu Baptouuuu self-assigned this May 18, 2025
@Baptouuuu Baptouuuu added the enhancement New feature or request label May 18, 2025
Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 90.36918% with 60 lines in your changes missing coverage. Please review.

Project coverage is 91.46%. Comparing base (2ec7178) to head (ec74cbe).
Report is 42 commits behind head on develop.

Files with missing lines Patch % Lines
src/Config.php 79.15% 59 Missing ⚠️
src/Filesystem.php 98.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             develop      #14       +/-   ##
==============================================
+ Coverage      72.13%   91.46%   +19.32%     
+ Complexity       185      126       -59     
==============================================
  Files             29       21        -8     
  Lines           1066      972       -94     
==============================================
+ Hits             769      889      +120     
+ Misses           297       83      -214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu marked this pull request as ready for review May 24, 2025 09:29
@Baptouuuu Baptouuuu merged commit 4150f6d into develop May 24, 2025
64 checks passed
@Baptouuuu Baptouuuu deleted the remove-interfaces branch May 24, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant