Skip to content

feat: PhotoSync with explicit wifi or 4G #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 1, 2025
Merged

feat: PhotoSync with explicit wifi or 4G #1440

merged 36 commits into from
Apr 1, 2025

Conversation

BaptGrv
Copy link
Contributor

@BaptGrv BaptGrv commented Feb 17, 2025 •
edited by adrien-coye
Loading

Depends on #1444
Depends on #1441
Depends on #1452
Depends on #1453
Depends on #1460
Depends on #1463
Depends on #1466
Depends on #1470
Depends on #1471
Depends on #1472

Superseding #1310

@BaptGrv BaptGrv requested a review from adrien-coye February 17, 2025 12:47
@adrien-coye adrien-coye mentioned this pull request Feb 17, 2025
Closed
adrien-coye
adrien-coye reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks left, almost there 👍

@adrien-coye adrien-coye mentioned this pull request Feb 21, 2025
Merged
adrien-coye
adrien-coye reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark

@BaptGrv BaptGrv force-pushed the feat/sync-mode-wifi branch from 758f3fe to a30a605 Compare February 21, 2025 12:12
@BaptGrv BaptGrv force-pushed the feat/sync-mode-wifi branch from 7c9bf49 to efe48e0 Compare February 21, 2025 13:47
adrien-coye
adrien-coye approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing of the PR
I found a tiny UI glitch when the queue is suspended, it hides an upload.
I also found a strange bug related but not caused by the PR that I want to investigate before I make a new beta.

I will merge it later after further tests.

adrien-coye
adrien-coye reviewed Feb 24, 2025
View reviewed changes
@BaptGrv BaptGrv force-pushed the feat/sync-mode-wifi branch from 5816e7f to 516b38b Compare February 25, 2025 10:18
adrien-coye
adrien-coye reviewed Feb 25, 2025
View reviewed changes
@adrien-coye adrien-coye mentioned this pull request Feb 25, 2025
Merged
@BaptGrv BaptGrv force-pushed the feat/sync-mode-wifi branch from 76d0187 to 8d5f25a Compare February 26, 2025 07:54
adrien-coye
adrien-coye requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to make sure the "Sync offline files" is used by the DownoadQueue.

@adrien-coye adrien-coye mentioned this pull request Feb 28, 2025
Merged
@BaptGrv BaptGrv force-pushed the feat/sync-mode-wifi branch from c341f8a to 72b65f3 Compare March 4, 2025 14:17
@adrien-coye adrien-coye added this to the 5.3.0 milestone Mar 5, 2025
@BaptGrv BaptGrv force-pushed the feat/sync-mode-wifi branch from 72b65f3 to d316336 Compare March 5, 2025 08:11
@github-actions github-actions bot removed the dependent label Mar 5, 2025
@adrien-coye adrien-coye mentioned this pull request Mar 5, 2025
Closed
1 task
@adrien-coye adrien-coye removed this from the 5.3.0 milestone Mar 17, 2025
@adrien-coye adrien-coye force-pushed the feat/sync-mode-wifi branch from 7d7bad7 to 0d9637d Compare March 17, 2025 13:34
@adrien-coye adrien-coye force-pushed the feat/sync-mode-wifi branch from 0d9637d to 3a6b4b0 Compare March 26, 2025 07:37
adrien-coye and others added 20 commits April 1, 2025 11:57
@adrien-coye
refactor(UploadQueue): New updateQueueSuspension public function
89a8b44
@adrien-coye
fix(PhotoSyncSettingsViewController): Update upload queue on save pho…
1c18dbf 
…to sync settings
@BaptGrv @adrien-coye
feat: Manage download of offline files with wifiOnly or cellular
5a25759
@BaptGrv @adrien-coye
refactor: Replace downloadQueue by downloadQueueable
4924563
@adrien-coye
chore: Update kDriveCore/Data/DownloadQueue/DownloadQueue.swift
f0b2e30 
Signed-off-by: adrien-coye <adrien.coye@infomaniak.com>
@BaptGrv @adrien-coye
fix: Change default value for syncOfflineMode
c20c6e3
@adrien-coye
feat: Making the upload4G branch work on top of the dedicated UploadQ…
5d8b6f2 
…ueue
@adrien-coye
feat(PhotoUploadQueue): Specific upload queue logic for the dedicated…
7a4ba81 
… PhotoUploadQueue
@adrien-coye
refactor: Renamed the variable isSuspended to make Sonar happy
68c6f81
@adrien-coye
fix(UploadOperation): Check if a photo upload should stop on a chunk …
1a61fef 
…by chunk basis
@adrien-coye
refactor(UploadOperation): Use new helper method
3ec076b
@adrien-coye
fix(UploadTableViewCell): Display wifi required error only for photo …
2d513b2 
…upload assets
@adrien-coye
refactor(UploadTableViewCell): Modern if syntax
6e0a1e4
@adrien-coye
fix(UploadTableViewCell): Show wifi required message only when needed
66833ed
@adrien-coye
refactor(UploadTableViewCell): Explicit that a file is live
acd80a5
@adrien-coye
fix(WorkloadParallelismHeuristic): Refresh parallelism on network change
d8c65a3
@adrien-coye
fix(UploadOperation): Do not force the photo upload queue to stop on …
d8c1d79 
…error, ask the service to refresh instead
@adrien-coye
chore(UploadParallelismOrchestrator): Remove assertion
087b721
@adrien-coye
refactor(UploadService): Use correct serial queue to update suspensio…
5821767 
…n on network change
@adrien-coye
refactor(UploadQueue): Explicit which upload queue is emitting a log …
c94239a 
…event
@adrien-coye adrien-coye force-pushed the feat/sync-mode-wifi branch from f637565 to c94239a Compare April 1, 2025 09:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adrien-coye
adrien-coye approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test this branch extensively today.
The migration of networking sync settings in correct.
I also took the time to stress the network switching capabilities and recovery of this branch.
It is now ready for a beta 🚀

@adrien-coye
Copy link
Contributor

CI is failing for API reasons, force merging now

@adrien-coye adrien-coye merged commit 11b9529 into master Apr 1, 2025
7 of 8 checks passed
@adrien-coye adrien-coye deleted the feat/sync-mode-wifi branch April 1, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@BaptGrv @adrien-coye