Integrate unity test framework #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
ramya-subramanyam
force-pushed
the
integrate-unity-test-framework
branch
from
112b7df to
cba6e7d
Compare
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
jaenrig-ifx
approved these changes
Nov 1, 2024
test/unit/src/Test_common_includes.h
Outdated
| #include <stdbool.h> | ||
|
|
||
|
|
||
| // project c includes |
There was a problem hiding this comment.
Not sure if this test_common_includes.h and test_includes.h is necessary?
I would also try to stick to snake_case o kebak-case if possible for the files which are not required to start with capital case. Or files which do not include cpp classes, which usually use CamelCase.
There was a problem hiding this comment.
I fixed the test file name to snake case already, I remove one of the include file test_common_includes.h but kept test_includes.h to include unity header files... We can include only test_includes.h file in all the tests.
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Provide the information we need to review your PR. What problem does the pull request solve? "Bug fix" is not a good description.
Related Issue
If you opened an issue before creating the PR, point to it here.
Context
What do we need to know about your development environment, tools, target, and so on. Screenshots are always helpful if there is a UI element to this PR.