Skip to content

cores/psoc6: ./docs: ./tests: Implement Pulse. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

ramya-subramanyam
Copy link
Collaborator

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Implementation of following APIs:
https://docs.arduino.cc/language-reference/en/functions/advanced-io/pulseIn/
https://docs.arduino.cc/language-reference/en/functions/advanced-io/pulseInLong/

Corresponding tests: Infineon/arduino-core-tests#47

Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the Arduino pulseIn and pulseInLong APIs on PSoC6, adds corresponding tests and documentation updates, and includes a new CI example.

  • Added Pulse.cpp with timer-based pulseIn/pulseInLong implementation
  • Extended tests for pulse functionality and updated test configuration
  • Updated documentation (arduino-deviations.rst) and CI matrix to include tone and sensor examples

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/test_config.h Defined TEST_PIN_PULSE and renamed ADC macro for tests
tests/cy8ckit-062s2-ai-hil-test-table.md Fixed table formatting and added Advanced IO Pulse/Tone
docs/arduino-deviations.rst Standardized naming and added tone docs
cores/psoc6/Pulse.cpp New implementation of pulseIn/pulseInLong
ci-matrix-config.yml Included Memsic2125 sensor example
Comments suppressed due to low confidence (2)

tests/test_config.h:29

  • [nitpick] The macro has been renamed from ADC_RESOLUTION to TEST_ADC_RESOLUTION, but any existing references to ADC_RESOLUTION in tests will need updating. Consider restoring the original name or updating all usages for consistency.
#define         TEST_ADC_RESOLUTION             2048    // 11-bit resolution

docs/arduino-deviations.rst:4

  • The casing PSOC6-for-Arduino is inconsistent with the official PSoC6-for-Arduino branding. Update to match the standard capitalization.
This section documents the differences between the standard Arduino Language Reference and `PSOC6-for-Arduino`.

@Infineon Infineon deleted a comment from Copilot AI May 30, 2025
@Infineon Infineon deleted a comment from Copilot AI May 30, 2025
@Infineon Infineon deleted a comment from Copilot AI May 30, 2025
@Infineon Infineon deleted a comment from Copilot AI May 30, 2025
Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@ramya-subramanyam ramya-subramanyam merged commit 120a864 into main May 30, 2025
15 checks passed
@ramya-subramanyam ramya-subramanyam deleted the psoc-ino-pulse branch May 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants