Core api update tone #351
Core api update tone #351
Conversation
dineshgit411
force-pushed
the
core-api-update-tone
branch
from
7f9266f to
9e79031
Compare
| XMC_GPIO_MODE_OUTPUT_PUSH_PULL | pwm4->port_mode); | ||
| XMC_CCU4_SLICE_StartTimer(pwm4->slice); | ||
| // count pulses for stop the timer once reached required pulses | ||
| if (duration > 0) { |
There was a problem hiding this comment.
So if a duration is set the function is blocking or?
There was a problem hiding this comment.
yep, I will change the logic. before, I used timer but one test case got failed due to time variation(100ms)
I will revisit and change.
| @@ -73,6 +73,8 @@ extern "C" { | |||
|
|
|||
| #define interrupts() __enable_irq() | |||
| #define noInterrupts() __disable_irq() | |||
| #define ENABLED 1 | |||
There was a problem hiding this comment.
Where are these defines used?
There was a problem hiding this comment.
In pins_arduino.h for ADC and PWM pins configurationsL like here: https://github.com/Infineon/XMC-for-Arduino/blob/master/variants/XMC4700/config/XMC4700_Relax_Kit/pins_arduino.h#L331
Maybe modify macro to be XMC_ENABLED or simply use false/true for all xmc struct.
There was a problem hiding this comment.
Yes the naming is too generic for potential conflict with any other code not coming from XMC deciding to declare such.
We have already experienced that with macros like GPIO, ADC and such.
They help to understand more what that flag/variable does. But this is also not user level code, so maybe the simplest is to stay with true and false :)
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Signed-off-by: zhanglinjing <Linjing.Zhang@infineon.com>
LinjingZhang
force-pushed
the
core-api-update-tone
branch
from
0582e0f to
2911542
Compare
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Tone function implemented using PWM method. In XMC we have two modes CCU4 and CCU8 . configured for all the PWM pins.
Related Issue
Removed delay in test_main.ino because test case not running in continuous loop.
Context
Tested with 4700 Board, connected jumber wire in between interrupt pin and pwm pin.