Skip to content

remove doc extraction, review, and dataset classes #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

Scott771
Copy link
Contributor

This is the beginning of removing functionality that is no longer maintained or utilized-- additional PRs will follow

@Scott771 Scott771 changed the base branch from main to dev_6_14_2 March 31, 2025 18:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes functionality that is no longer maintained or utilized, specifically eliminating classes and tests related to document extraction, reviewer handling, dataset operations, auto-population, and associated examples.

  • Removed integration tests for Reviewer, DocExtraction, and Datasets.
  • Removed corresponding modules and examples that depended on these functionalities.
  • Updated import references across the codebase to reflect the removals.

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/integration/indico_wrapper/test_reviewer.py Removed tests related to reviewer functionality.
tests/integration/indico_wrapper/test_doc_extraction.py Removed tests for document extraction features.
tests/integration/indico_wrapper/test_dataset.py Removed tests for dataset functionality.
tests/integration/conftest.py Removed fixtures that depended on the removed DocExtraction and related classes.
indico_toolkit/ocr/customocr_object.py Removed the CustomOcr class, cleaning up unused OCR logic.
indico_toolkit/ocr/init.py Updated all to reflect removal of CustomOcr.
indico_toolkit/indico_wrapper/reviewer.py Removed the Reviewer class and its associated GraphQL queries.
indico_toolkit/indico_wrapper/doc_extraction.py Removed the DocExtraction class handling OCR extraction.
indico_toolkit/indico_wrapper/dataset.py Removed the Datasets class and its dataset management methods.
indico_toolkit/indico_wrapper/init.py Removed references to the removed classes and updated exports accordingly.
indico_toolkit/auto_populate/types.py Removed auto-populate type definitions.
indico_toolkit/auto_populate/populator.py Removed the AutoPopulator class used for workflow and teach task population.
indico_toolkit/auto_populate/init.py Removed auto_populate init file, cleaning up module exports.
examples/* Removed multiple example scripts that relied on the removed functionalities.
Files not reviewed (1)
  • mypy.ini: Language not supported

@Scott771 Scott771 merged commit 4b1696b into dev_6_14_2 Apr 1, 2025
6 checks passed
@Scott771 Scott771 deleted the begin_removal branch April 1, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants