Skip to content

Fix downsample directory assignment timing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix downsample directory assignment timing #21

merged 1 commit into from
Jul 26, 2024

Conversation

egrace479
Copy link
Member

Update downsample directory path naming to match image path convention. Addresses bug noticed in testing development in PR #20.

@egrace479 egrace479 added the bug Something isn't working label Jul 26, 2024
@egrace479 egrace479 requested a review from zoeduan July 26, 2024 14:56
zoeduan
zoeduan approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@zoeduan zoeduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the updated code with 'test_downsampled_image_creation', there is no error 'UnboundLocalError for downsample_dir'

@zoeduan
Copy link
Collaborator

zoeduan commented Jul 26, 2024

LGTM

@egrace479 egrace479 merged commit ee4e892 into main Jul 26, 2024
2 checks passed
@egrace479 egrace479 deleted the bug/downsample branch August 1, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoeduan zoeduan zoeduan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egrace479 @zoeduan