-
Notifications
You must be signed in to change notification settings - Fork 0
Add more test cases for cautious-robot #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4f7b4f6
Add more test cases for cautious-robot
zoeduan 7aeeb31
Update tests/test_buddycheck.py
zoeduan f76bca7
Update tests/test_download_images.py
zoeduan be63bdd
update the test_buddycheck.py: 1. add another buddycheck instance wit…
zoeduan cbb2696
Merge branch 'feature/enhance-testing' of github.com:Imageomics/cauti…
zoeduan ac351d0
Merge remote-tracking branch 'origin/main' into feature/enhance-testing
zoeduan 84e3db2
update test_logging
zoeduan 8ede4e4
Update tests/test_buddycheck.py
zoeduan b182c43
Update tests/test_buddycheck.py
zoeduan 705c3a7
Update tests/test_buddycheck.py
zoeduan 8b803ab
Update tests/test_buddycheck.py
zoeduan 6e9a6f9
Update tests/test_buddycheck.py
zoeduan ced10d5
Update tests/test_buddycheck.py
zoeduan 66e9328
Update tests/test_buddycheck.py
zoeduan e01a1e6
Update tests/test_buddycheck.py
zoeduan 36f2a08
remove test_check_alignment_case_insensitive_columns
zoeduan c527cec
Replace the retry template with a loop over retry codes to handle bot…
zoeduan 279ea43
Update test_downsampled_image_creation
zoeduan 4947850
Update tests/test_buddycheck.py
zoeduan 1c7b535
Update tests/test_buddycheck.py
zoeduan e92f93a
1. Update test_success_after_retries and test_failure_after_retries 2…
zoeduan 2a31f5c
fix downsize read bug
egrace479 463d147
Update test_downsampled_image_creation(_with_subfolder)
zoeduan fd9f8b2
Updated test_download_images.py to make it run faster
zoeduan d752b8d
Update tests/test_download_images.py
zoeduan 16bda3a
Update tests/test_download_images.py
zoeduan 90237f1
"Add sample images from Rare-Species dataset (8511cb36-ea18-419a-b938…
zoeduan df58073
Custom error when validating empty input df
thompsonmj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
import unittest | ||
from unittest.mock import patch | ||
import pandas as pd | ||
import tempfile | ||
import os | ||
from cautiousrobot import BuddyCheck | ||
from cautiousrobot.utils import process_csv | ||
|
||
class TestBuddyCheck(unittest.TestCase): | ||
def setUp(self): | ||
self.buddy_check = BuddyCheck() | ||
self.buddy_check_filename = BuddyCheck(buddy_id='filename') | ||
|
||
self.img_source_file = tempfile.NamedTemporaryFile(delete=False, mode='w') | ||
self.checksum_source_file = tempfile.NamedTemporaryFile(delete=False, mode='w') | ||
|
||
self.img_source_file.write("""filename,checksum | ||
image1.jpg,abc123 | ||
image2.jpg,def456 | ||
image3.jpg,ghi789 | ||
""") | ||
self.img_source_file.close() | ||
|
||
self.checksum_source_file.write("""filename,md5 | ||
image1.jpg,abc123 | ||
image2.jpg,def456 | ||
image3.jpg,ghi789 | ||
""") | ||
self.checksum_source_file.close() | ||
|
||
|
||
def tearDown(self): | ||
os.remove(self.img_source_file.name) | ||
os.remove(self.checksum_source_file.name) | ||
|
||
def test_initialization(self): | ||
self.assertEqual(self.buddy_check.buddy_id, None) | ||
self.assertEqual(self.buddy_check.buddy_col, 'md5') | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
def test_merge_on_checksum(self): | ||
source_df = pd.read_csv(self.img_source_file.name) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name).drop(columns=['filename']) | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
merged_df = self.buddy_check_filename.merge_on_checksum(source_df, checksum_df, 'checksum') | ||
expected_df = pd.DataFrame({ | ||
'filename': ['image1.jpg', 'image2.jpg', 'image3.jpg'], | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
'checksum': ['abc123', 'def456', 'ghi789'], | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
'md5': ['abc123', 'def456', 'ghi789'] | ||
}) | ||
pd.testing.assert_frame_equal(merged_df, expected_df) | ||
|
||
def test_merge_on_filename_checksum(self): | ||
source_df = pd.read_csv(self.img_source_file.name) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name) | ||
merged_df = self.buddy_check_filename.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
expected_df = pd.DataFrame({ | ||
'filename': ['image1.jpg', 'image2.jpg', 'image3.jpg'], | ||
'checksum': ['abc123', 'def456', 'ghi789'], | ||
'md5': ['abc123', 'def456', 'ghi789'] | ||
}) | ||
pd.testing.assert_frame_equal(merged_df, expected_df) | ||
|
||
def test_check_alignment_all_matching(self): | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
source_df = pd.read_csv(self.img_source_file.name) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name) | ||
merged_df = self.buddy_check_filename.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
missing_imgs = self.buddy_check_filename.check_alignment(source_df, merged_df) | ||
self.assertIsNone(missing_imgs) | ||
|
||
def test_check_alignment_some_missing(self): | ||
source_df = pd.DataFrame({ | ||
'filename': ['image1.jpg', 'image2.jpg', 'image3.jpg', 'image4.jpg'], | ||
'checksum': ['abc123', 'def456', 'ghi789', 'jkl012'] | ||
}) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name) | ||
print(checksum_df) | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
merged_df = self.buddy_check_filename.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
missing_imgs = self.buddy_check_filename.check_alignment(source_df, merged_df) | ||
expected_missing_imgs = pd.DataFrame({ | ||
'filename': ['image4.jpg'], | ||
'checksum': ['jkl012'] | ||
}) | ||
pd.testing.assert_frame_equal(missing_imgs.reset_index(drop=True), expected_missing_imgs) | ||
|
||
def test_validate_download_success(self): | ||
missing_imgs = self.buddy_check.validate_download( | ||
source_df=pd.read_csv(self.img_source_file.name), | ||
checksum_df=pd.read_csv(self.checksum_source_file.name).drop(columns=['filename']), | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
source_id_col="filename", | ||
source_validation_col="checksum" | ||
) | ||
self.assertIsNone(missing_imgs) | ||
|
||
def test_validate_download_missing_images(self): | ||
source_df = pd.DataFrame({ | ||
'filename': ['image1.jpg', 'image2.jpg', 'image3.jpg', 'image4.jpg'], | ||
'checksum': ['abc123', 'def456', 'ghi789', 'jkl012'] | ||
}) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name) | ||
missing_imgs = self.buddy_check_filename.validate_download( | ||
source_df=source_df, | ||
checksum_df=checksum_df, | ||
source_id_col="filename", | ||
source_validation_col="checksum" | ||
) | ||
expected_missing_imgs = pd.DataFrame({ | ||
'filename': ['image4.jpg'], | ||
'checksum': ['jkl012'] | ||
}) | ||
pd.testing.assert_frame_equal(missing_imgs.reset_index(drop=True), expected_missing_imgs) | ||
|
||
def test_check_alignment_no_matching(self): | ||
source_df = pd.read_csv(self.img_source_file.name) | ||
checksum_df = pd.DataFrame({ | ||
'filename': ['image4.jpg', 'image5.jpg', 'image6.jpg'], | ||
'md5': ['xyz123', 'uvw456', 'rst789'] | ||
}) | ||
merged_df = self.buddy_check_filename.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
missing_imgs = self.buddy_check_filename.check_alignment(source_df, merged_df) | ||
self.assertIsNotNone(missing_imgs) | ||
self.assertEqual(missing_imgs.shape[0], 3) | ||
|
||
def test_check_alignment_checksums_only(self): | ||
source_df = pd.read_csv(self.img_source_file.name) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name).drop(columns=['filename']) | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
merged_df = self.buddy_check.merge_on_checksum(source_df, checksum_df, 'checksum') | ||
missing_imgs = self.buddy_check.check_alignment(source_df, merged_df) | ||
self.assertIsNone(missing_imgs) | ||
|
||
def test_check_alignment_empty_img_df(self): | ||
source_df = pd.DataFrame(columns=['filename', 'checksum']) | ||
checksum_df = pd.read_csv(self.checksum_source_file.name) | ||
merged_df = self.buddy_check.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
missing_imgs = self.buddy_check.check_alignment(source_df, merged_df) | ||
self.assertIsNone(missing_imgs) | ||
|
||
def test_check_alignment_empty_checksum_df(self): | ||
source_df = pd.read_csv(self.img_source_file.name) | ||
checksum_df = pd.DataFrame(columns=['filename', 'md5']) | ||
self.buddy_check.buddy_id = 'filename' | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
merged_df = self.buddy_check.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
missing_imgs = self.buddy_check.check_alignment(source_df, merged_df) | ||
self.assertIsNotNone(missing_imgs) | ||
self.assertEqual(missing_imgs.shape[0], 3) | ||
|
||
def test_check_alignment_case_insensitive_columns(self): | ||
zoeduan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
source_df = pd.DataFrame({ | ||
'FILENAME': ['image1.jpg', 'image2.jpg', 'image3.jpg'], | ||
'CHECKSUM': ['abc123', 'def456', 'ghi789'] | ||
}) | ||
checksum_df = pd.DataFrame({ | ||
'FILENAME': ['image1.jpg', 'image2.jpg', 'image3.jpg'], | ||
'MD5': ['abc123', 'def456', 'ghi789'] | ||
}) | ||
source_df.columns = source_df.columns.str.lower() | ||
checksum_df.columns = checksum_df.columns.str.lower() | ||
merged_df = self.buddy_check_filename.merge_on_filename_checksum(source_df, checksum_df, 'filename', 'checksum') | ||
missing_imgs = self.buddy_check_filename.check_alignment(source_df, merged_df) | ||
self.assertIsNone(missing_imgs) | ||
|
||
if __name__ == '__main__': | ||
unittest.main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.