fix: restore path based parsing in 4.0 #566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue 564 also safely wraps strings for parsing [564]
nnungest
force-pushed
the
fix/parse-parent-dirs
branch
from
8847853 to
2c0c026
Compare
|
Im not sure if the last 2 checks apply to this PR but im happy to update things if needed. In this case I don't think the test should be touched as this should keep the same functionality as before intact. |
GrassBlock1
added a commit
to BlockG-ws/tide
that referenced
this pull request
Mar 10, 2025
|
Thanks! this fixed my issue. Looks like @IlanCosman hasn't been active much recently, but hopefully this makes its way in |
ly4096x
added a commit
to ly4096x/tide
that referenced
this pull request
Mar 14, 2025
ly4096x
added a commit
to ly4096x/tide
that referenced
this pull request
Mar 14, 2025
* remove _tide_cache_variables * apply IlanCosman#566 * update makefile * fix * fix color * fix indent
|
Thanks! |
faho
suggested changes
Mar 18, 2025
credit to @scaryrawr where credit is due.
|
Thank you. Hope to merge soon！ |
|
It seems the owner is not very active anymore. Is anyone willing to start a fork? |
ive since started using starship instead. |
|
For what it's worth, I've started going through the various PRs here on the fork I created and seeing about getting them merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 564, where empty directories are returned after upgrading to 4.0.0. This also safely wraps paths.
Description
Restore path based parsing for a variety of _tide_item functions.
Motivation and Context
When a user changes directory into a one that contains, lets say package.json, tide normally picks up the version and prints it on the status line. This stopped working when fish moved to 4.0.0. This restores the previous behavior by checking for directories that are invalid (zero length) and safely wrapping the directories with quotes.
Closes #564
Screenshots (if appropriate)
How Has This Been Tested
I ran this against the make commands list in contributing.
Checklist