fix(*): replacing deprecated jQuery calls #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChronosSF
changed the title
kdinev
reviewed
Feb 28, 2025
| @@ -720,7 +720,7 @@ | |||
| this.handles.attr("disabled", "disabled"); | |||
| this.element.addClass("ui-disabled"); | |||
| } else { | |||
| this.handles.removeAttr("disabled"); | |||
| this.handles[0].removeAttribute("disabled"); | |||
There was a problem hiding this comment.
Why is this needed if attr() is still supported?
There was a problem hiding this comment.
Apparently removeAttr should no longer be used when handling boolean attributes. It's being reported by jQuery migrate.
For tags that understand e.g. disabled (such as input), we could use removeProp which is the suggested way but in our code we freely use these on divs and such and removeProp actually sets them to false . (yeah it's a mess)
kdinev
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER
Additional information (check all that apply):
Checklist:
README.MD