Support multi-arch builds with separate workers #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmichaud
force-pushed
the
multiarch-builds
branch
2 times, most recently
from
ef351f0 to
94c3f2c
Compare
TingPing
reviewed
Mar 27, 2025
TingPing
reviewed
Mar 27, 2025
justinmichaud
force-pushed
the
multiarch-builds
branch
2 times, most recently
from
e98d8c0 to
d5311e4
Compare
TingPing
requested changes
Apr 7, 2025
justinmichaud
force-pushed
the
multiarch-builds
branch
3 times, most recently
from
65c821a to
7b09b5c
Compare
|
@justinmichaud any news here? |
justinmichaud
force-pushed
the
multiarch-builds
branch
2 times, most recently
from
cf09148 to
e6d9b26
Compare
nikolaszimmermann
approved these changes
May 12, 2025
There was a problem hiding this comment.
Looks good just a few small questions. @TingPing please check as well, since you created the tagging logic.
TingPing
approved these changes
May 12, 2025
For now, we only build the intel image. I have locally tested that this works with arm64 too.
- Always tag images, so that we can easily tar and untar them
- Download images from the build${arch} job, and create a multi-arch manifest
justinmichaud
force-pushed
the
multiarch-builds
branch
from
e6d9b26 to
e5fd6ed
Compare
justinmichaud
added a commit
that referenced
this pull request
May 13, 2025
This reverts commit bdfcced.
|
This was reverted because it failed to deploy, I will debug the issue locally |
justinmichaud
added a commit
to justinmichaud/webkit-container-sdk
that referenced
this pull request
May 13, 2025
For now, we only build the intel image. I have locally tested that this
works with arm64 too.
- Always tag images, so that we can easily tar and untar them
- Download images from the build${arch} job, and create a multi-arch
manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we only build the intel image. I have locally tested that this works with arm64 too.