Skip to content

[Presentation] Mdoc Cbor disclosure map #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pymdoccbor/mdoc/issuer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
import binascii
import cbor2
import logging
import datetime
from datetime import datetime, timezone
from cryptography.hazmat.primitives import serialization
from cryptography.hazmat.primitives.asymmetric.ec import EllipticCurvePublicKey
from pycose.keys import CoseKey, EC2Key
from typing import Union

from pymdoccbor.mso.issuer import MsoIssuer

from cbor_diag import *
from cbor_diag import cbor2diag


logger = logging.getLogger("pymdoccbor")
Expand Down Expand Up @@ -159,7 +159,7 @@ def new(
revocation=revocation
)

mso = msoi.sign(doctype=doctype, device_key=devicekeyinfo,valid_from=datetime.datetime.now(datetime.UTC))
mso = msoi.sign(doctype=doctype, device_key=devicekeyinfo,valid_from=datetime.now(timezone.utc))

mso_cbor = mso.encode(
tag=False,
Expand Down
31 changes: 31 additions & 0 deletions pymdoccbor/mdoc/verifier.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def __init__(self) -> None:

self.documents: List[MobileDocument] = []
self.documents_invalid: list = []
self.disclosure_map: dict = {}

def loads(self, data: str) -> None:
"""
Expand Down Expand Up @@ -134,6 +135,33 @@ def dumps(self) -> bytes:
@property
def data_as_string(self) -> str:
return self.dumps().decode()

def _decode_claims(self, claims: list[dict]) -> dict:
decoded_claims = {}

for claim in claims:
decoded = cbor2.loads(claim.value)

if isinstance(decoded['elementValue'], cbor2.CBORTag):
decoded_claims[decoded['elementIdentifier']] = decoded['elementValue'].value
elif isinstance(decoded['elementValue'], list):
claims_list = []

for element in decoded['elementValue']:
claims_dict = {}
for key, value in element.items():
if isinstance(value, cbor2.CBORTag):
claims_dict[key] = value.value
else:
claims_dict[key] = value
claims_list.append(claims_dict)

decoded_claims[decoded['elementIdentifier']] = claims_list
else:
decoded_claims[decoded['elementIdentifier']] = decoded['elementValue']

return decoded_claims


def verify(self) -> bool:
""""
Expand All @@ -160,6 +188,9 @@ def verify(self) -> bool:
else:
self.documents_invalid.append(mso)

for namespace, claims in mso.issuersigned.namespaces.items():
self.disclosure_map[namespace] = self._decode_claims(claims)

except Exception as e:
logger.error(
f"COSE Sign1 validation failed to the document number #{doc_cnt}. "
Expand Down
4 changes: 3 additions & 1 deletion pymdoccbor/tests/test_08_mdoc_cbor.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,6 @@ def test_mdoc_cbor_creation():
mdocp.loads(data)
mdocp.verify()

assert mdoc
assert mdoc
assert 'org.micov.medical.1' in mdocp.disclosure_map
assert mdocp.disclosure_map == MICOV_DATA
3 changes: 0 additions & 3 deletions pymdoccbor/x509.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import datetime
import os

from cwt import COSEKey
from typing import Union

Expand Down