Fix: Add compatibility for django-csp 4.x in CSP update decorator #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcrtexidor I did not see your PR, I made something very similar in #417 . I'm happy if either of the PRs are merged. Also, the Readme mentions making PRs against the |
|
@gabriels1234 could you please merge @jcrtexidor commints into your branch and fix the conflicts, to have him in our officialc contributors in the next release? I would therefore merge your last PR I should align dev branch with the master one. Thank you for having raised this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
_django_csp_update_decoratorto support both legacy (<4.0) and modern (>=4.0)versions of
django-csp, addressing the breaking change in decorator arguments.The version is checked dynamically using
importlib.metadata.version.