Skip to content

✨ Add Controller for /me/function-permissions Endpoint in Functions Domain #7901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 13, 2025

What do these changes do?

ReDoc

image

This PR introduces a controller in the functions domain that serves the GET /me/function-permissions endpoint, as required by the front-end in #7888.

It leverages the existing service-layer functionality exposed in #7868 via _functions_service.get_functions_user_api_access_rights.

The implementation follows a minimalistic approach, focusing on fulfilling the immediate client requirements, while being structured to allow easy future extensions (e.g. expanding the response model or improving test coverage).

  • NOTE: @odeimaiz due to camel-case rule, you have to modify a bit the fields you use in your response model.

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/04/functions_rpc -k test_list_user_functions_permissions

Dev-ops

None

@pcrespov pcrespov self-assigned this Jun 13, 2025
@pcrespov pcrespov added this to the Engage milestone Jun 13, 2025
@pcrespov pcrespov added release Preparation for pre-release/release a:webserver issue related to the webserver service labels Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.55%. Comparing base (23a82ba) to head (124caa7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7901      +/-   ##
==========================================
- Coverage   87.88%   87.55%   -0.34%     
==========================================
  Files        1779     1461     -318     
  Lines       68271    60316    -7955     
  Branches     1220      476     -744     
==========================================
- Hits        60000    52807    -7193     
+ Misses       7919     7388     -531     
+ Partials      352      121     -231     
Flag Coverage Δ
integrationtests 64.21% <55.55%> (+0.40%) ⬆️
unittests 85.70% <63.63%> (-0.78%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.25% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.99% <ø> (-0.06%) ⬇️
agent 96.29% <ø> (ø)
api_server 91.84% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.11% <ø> (+0.68%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 88.98% <ø> (ø)
storage 87.46% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 81.58% <55.55%> (-5.90%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a82ba...124caa7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title Is1901/function permisions rest ✨ Add Controller for /me/function-permissions Endpoint in Functions Domain Jun 13, 2025
@pcrespov pcrespov force-pushed the is1901/function-permisions-rest branch from 6e195c5 to 124caa7 Compare June 13, 2025 16:02
Copy link

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service release Preparation for pre-release/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants