🎨 Add fallback traefik 503 routes 🚨⚠️ DEVOPS #7899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fallback routes that will take effect once main services (e.g. webserver is not in `running` state). Once service is not in `running` state, its configuration is removed from traefik leading to 404. Related Issue(s): * ITISFoundation/osparc-ops-environments#218 Related PR(s): * ITISFoundation/osparc-ops-environments#950
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7899 +/- ##
==========================================
+ Coverage 87.97% 88.00% +0.02%
==========================================
Files 1844 1837 -7
Lines 71048 70858 -190
Branches 1220 1220
==========================================
- Hits 62508 62361 -147
+ Misses 8188 8145 -43
Partials 352 352
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add fallback routes that will take effect once main services (e.g. webserver is not in
runningstate). This fallback routes will trigger 503 traefik default response which is a proper response when simcore service is not inrunningstate.By default traefik removes configuration of services that are not in running state (this leads to
404) traefik/traefik#7842Next steps
Ship relevant html / json content back to users. We need to discuss what is proper content and in which scenarios we need to serve it.
Implementation details
https://doc.traefik.io/traefik/providers/swarm/#allowemptyservices traefik configuration setting was tested but had no effect as reported in traefik/traefik#11827
We don't have traefik healthcheck for
simcore traefik. Since we need to introduce healthcheck per traefik-service and simcore traefik defines multiple of those, introducing extra 3 calls on traefik service might be an overkill. It is not clear is this healthcheck makes sense in general as it runs against traefik itself 🤷Related issue/s
Related PR(s)
invitaitonsservice as its traefik config lives inopsreposimcore traefik(this routes configureops traefik)How to test
Scale exposed simcore service (e.g.
webserverto0replicas). Open platform in browser and ensure you get503error withUnavailable servicemessage (instead of404 not found)Dev-ops