Skip to content

🐛 [Frontend] Fix: Nodes seem unconnected during running of services #7895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2025
Merged

🐛 [Frontend] Fix: Nodes seem unconnected during running of services #7895

merged 3 commits into from
Jun 13, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 13, 2025 •
edited
Loading

What do these changes do?

It would only happen when the lock that shows up while node is running would make the node resize.

Fixed

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz requested a review from Copilot June 13, 2025 11:59
@odeimaiz odeimaiz self-assigned this Jun 13, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 13, 2025
Copilot
Copilot AI reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses an issue by modifying the behavior in the NodeUI component.

  • The commented-out resize listener has been left inactive, potentially affecting node decorator updates.

@odeimaiz odeimaiz changed the title fix 🐛 [Frontend] Fix: Nodes seem unconnected during running of services Jun 13, 2025
@odeimaiz odeimaiz added this to the Engage milestone Jun 13, 2025
@odeimaiz odeimaiz marked this pull request as ready for review June 13, 2025 12:02
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 13, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 21c1a19

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit 21c1a19 into ITISFoundation:master Jun 13, 2025
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Engage
Development

Successfully merging this pull request may close these issues.

Nodes seem unconnected during running of services
3 participants
@odeimaiz @GitHK @pcrespov