Skip to content

♻️ Extract Celery code to a new simcore library #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 94 commits into
base: master
Choose a base branch
from

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented May 19, 2025

What do these changes do?

This PR extracts the Celery wrapper logic from the existing storage module into a new dedicated simcore Celery package.

  • Introduces a new celery_library library with functions to setup and retrieve the Celery client and event loop.
  • Updates CI/CD workflows, CodeQL configuration, and Codecov settings to include the new package.

Related issue/s

How to test

cd packages/celery-library
make install-dev
make test-dev

Dev-ops

⚠️ New package has been added, this means new GitHub CI instructions.

@giancarloromeo giancarloromeo added this to the Bazinga! milestone May 19, 2025
@giancarloromeo giancarloromeo self-assigned this May 19, 2025
@giancarloromeo giancarloromeo added the a:storage issue related to storage service label May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 65.59633% with 75 lines in your changes missing coverage. Please review.

Project coverage is 87.62%. Comparing base (23a82ba) to head (687d848).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7698      +/-   ##
==========================================
- Coverage   87.88%   87.62%   -0.27%     
==========================================
  Files        1779     1430     -349     
  Lines       68271    59337    -8934     
  Branches     1220      649     -571     
==========================================
- Hits        60000    51992    -8008     
+ Misses       7919     7127     -792     
+ Partials      352      218     -134     
Flag Coverage Δ
integrationtests 64.26% <ø> (+0.45%) ⬆️
unittests 85.92% <65.59%> (-0.56%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library 73.96% <85.32%> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.03% <0.00%> (-0.56%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (+0.05%) ⬆️
agent 96.29% <ø> (ø)
api_server 91.85% <ø> (+<0.01%) ⬆️
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.82% <ø> (+0.09%) ⬆️
director_v2 91.09% <ø> (+0.67%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.09% <ø> (+0.10%) ⬆️
storage 86.16% <81.96%> (∅)
webclient ∅ <ø> (∅)
webserver 87.46% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a82ba...687d848. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo changed the title ♻️ Extract Celery code to a new package ♻️ Extract Celery code to a new simcore package May 19, 2025
@giancarloromeo giancarloromeo changed the title ♻️ Extract Celery code to a new simcore package ♻️ Extract Celery code to a new simcore package May 19, 2025
@giancarloromeo giancarloromeo changed the title ♻️ Extract Celery code to a new simcore package ♻️ Extract Celery code to a new simcore package ⚠️ May 20, 2025
@giancarloromeo giancarloromeo changed the title ♻️ Extract Celery code to a new simcore package ⚠️ ♻️ Extract Celery code to a new simcore library Jun 11, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants