Fix invalid wiring table error in bluesky tests #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fix test failure with bluesky having invalid wiring tables in some circumstances. Also delete
recover.run*
so all tests start with a clean ISISICP.Bluesky tests were not setting wiring tables like the DAE tests do
system_tests/test_genie_python_dae.py
Line 84 in dc1bbad
To Test
Strangely
System_Tests_Win11_Win11
was the only system test showing the issue. Have swapped this jenkins job onto the branch, so this is the "test". After merge put System_Tests_Win11_Win11 back on*/master
branchTicket
Link to Ticket
Acceptance criteria
List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
Final Steps