Skip to content

Fix invalid wiring table error in bluesky tests #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

FreddieAkeroyd
Copy link
Member

@FreddieAkeroyd FreddieAkeroyd commented Jun 4, 2025

Description of work

Fix test failure with bluesky having invalid wiring tables in some circumstances. Also delete recover.run* so all tests start with a clean ISISICP.

Bluesky tests were not setting wiring tables like the DAE tests do

setup_simulated_wiring_tables()
and so were relying on them being set previously, so depending on test order etc. you might get a failure with missing/invalid tables

To Test

Strangely System_Tests_Win11_Win11 was the only system test showing the issue. Have swapped this jenkins job onto the branch, so this is the "test". After merge put System_Tests_Win11_Win11 back on */master branch

Ticket

Link to Ticket

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Jun 4, 2025
@FreddieAkeroyd FreddieAkeroyd changed the title Fix no wiring table issue in tests Fix no wiring table error in bluesky tests Jun 4, 2025
@FreddieAkeroyd FreddieAkeroyd changed the title Fix no wiring table error in bluesky tests Fix invalid wiring table error in bluesky tests Jun 4, 2025
@rerpha rerpha merged commit 45f0adf into master Jun 5, 2025
4 checks passed
@rerpha rerpha deleted the fix_dae_tests branch June 5, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants