Skip to content

Fix race condition on initial value? #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Fix race condition on initial value? #130

merged 2 commits into from
Apr 28, 2025

Conversation

FreddieAkeroyd
Copy link
Member

@FreddieAkeroyd FreddieAkeroyd commented Apr 27, 2025

Description of work

Potentially fix error in test_GIVEN_waiting_for_exact_value_on_block_WHEN_block_wrong_value_THEN_timeout (test_genie_python_using_simple.TestWaitforBlock.test_GIVEN_waiting_for_exact_value_on_block_WHEN_block_wrong_value_THEN_timeout) - at moment it looks like a race condition on initial block value not getting reset quickly enough in test setup after it is changed in another test

Ticket

Link to Ticket

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Apr 27, 2025
@Chsudeepta Chsudeepta merged commit dad0daf into master Apr 28, 2025
4 checks passed
@FreddieAkeroyd FreddieAkeroyd deleted the maybe_fix_test branch June 9, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants