Skip to content

Archiver fast restart #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

Archiver fast restart #129

merged 5 commits into from
Apr 28, 2025

Conversation

FreddieAkeroyd
Copy link
Member

Description of work

Add test that a non-changing block is logged at least once under a variety of different run duration conditions

Ticket

ISISComputingGroup/IBEX#8720

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer

Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 20, 2025
View reviewed changes
@FreddieAkeroyd
pyright
ffa340e
@FreddieAkeroyd
Call direct rather than via thread
dfc51b8 
Test fails on timedelta part if use thread - not sure why,
seems second call to get_time_since_begin() in thread happens
15 seconds after first call!
@FreddieAkeroyd
ruff
bc1558d
@jackbdoughty jackbdoughty merged commit 9e48632 into master Apr 28, 2025
4 checks passed
@jackbdoughty jackbdoughty deleted the archiver_fast_restart branch April 28, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackbdoughty jackbdoughty jackbdoughty approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FreddieAkeroyd @jackbdoughty