Skip to content

typo #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

typo #24

merged 1 commit into from
Jun 12, 2025

Conversation

Tom-Willemsen
Copy link
Member

No description provided.

@Tom-Willemsen Tom-Willemsen moved this to Flash Review in Tasks Jun 12, 2025
@GRyall
Copy link
Member

GRyall commented Jun 12, 2025

The linked ticket suggests that this issue has been fixed? If so, is this line still needed? If not, what is going on?

@Tom-Willemsen
Copy link
Member Author

The line is trying to link to extra context behind why that is true / how we found it.

@GRyall
Copy link
Member

GRyall commented Jun 12, 2025

The line: "IBEX doesn’t like it so when a motor is moved to a negative direction, it uses BVEL speed instead of VELO"
The ticket acceptance criteria "Negative moves larger than BDST are run at VELO rather than BVEL for a motor with a setup similar to above (in particular with negative BDST)"
Freddie on ticket : "believe this is fixed in above PR"
Ticket is closed.

Combination of the above suggest that the documentation is out of date and the issue was fixed. That said, your proposed edit is a net gain as the correct ticket is referenced, so merging.

@GRyall GRyall merged commit be04330 into master Jun 12, 2025
2 checks passed
@rerpha rerpha deleted the fix_typo branch June 12, 2025 09:31
@Tom-Willemsen Tom-Willemsen removed this from Tasks Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants