feat: Concurrent executions with indexedDB Main Finalization #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #1328 +/- ##
============================================================
+ Coverage 92.79% 96.26% +3.46%
============================================================
Files 4 115 +111
Lines 236 3560 +3324
Branches 0 590 +590
============================================================
+ Hits 219 3427 +3208
- Misses 17 130 +113
- Partials 0 3 +3
... and 45 files with indirect coverage changes
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Finalizes the implementation of concurrent Digital Twin execution with IndexedDB integration for local persistence. Users can now start multiple executions simultaneously, view execution history, and manage executions through new UI components. This builds on version 0.8 changes including settings menu and interface design updates.
Key Changes
- Adds IndexedDB service for execution history persistence
- Implements concurrent execution support with execution status tracking
- Adds new execution history UI components with log viewing capabilities
Reviewed Changes
Copilot reviewed 120 out of 125 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/lib/test/integration/files.service.integration.spec.ts | Removes afterEach hook to fix test configuration |
| client/test/unit/route/digitaltwins/execution/ExecutionUIHandlers.test.ts | Adds comprehensive tests for execution UI handlers |
| client/test/unit/route/digitaltwins/execution/ExecutionStatusManager.test.ts | Updates import paths and adds type safety improvements |
| client/test/unit/route/digitaltwins/execution/ExecutionButtonHandlers.test.ts | Updates imports and adds execution ID parameter support |
| client/test/unit/model/backend/gitlab/execution/statusChecking.test.ts | Comments out null/undefined parameter tests |
| client/test/unit/model/backend/gitlab/execution/logFetching.test.ts | Removes null project ID test case |
| client/test/unit/database/digitalTwins.test.ts | Adds comprehensive IndexedDB service tests |
| client/test/unit/components/PrivateRoute.test.tsx | Adds mocks for new execution history components |
| client/test/preview/unit/util/*.test.ts | Updates import paths from preview/util to model/backend |
| client/test/unit/components/execution/ExecutionHistoryList.test.tsx | Adds comprehensive tests for execution history UI component |
| client/test/unit/components/asset/*.test.tsx | Updates component tests for new execution history functionality |
| client/test/preview/unit/store/executionHistory.slice.test.ts | Adds comprehensive Redux slice tests |
| client/test/preview/unit/store/Store.test.ts | Updates for new Redux state structure |
| client/test/preview/unit/routes/digitaltwins/manage/*.test.tsx | Updates for new adapter pattern |
| client/test/preview/unit/routes/digitaltwins/execute/*.test.tsx | Updates imports and adds execution history tests |
| client/test/preview/integration/**/*.test.tsx | Updates integration tests for new execution patterns |
| client/test/e2e/tests/*.test.ts | Adds end-to-end tests for concurrent execution |
| client/src/util/digitalTwinAdapter.ts | Adds adapter pattern for bridging Redux state and business logic |
| client/src/store/store.ts | Adds execution history slice to Redux store |
| client/src/store/snackbar.slice.ts | Simplifies snackbar hide logic |
| client/src/store/selectors/*.ts | Adds selectors for execution history and digital twin state |
| client/src/route/digitaltwins/Snackbar.tsx | Updates import path for snackbar slice |
| client/src/preview/store/cart.slice.ts | Updates import path for LibraryAsset |
Comments suppressed due to low confidence (2)
servers/lib/test/integration/files.service.integration.spec.ts:1
- The removal of afterEach hook may cause test isolation issues if mocks are not properly reset between tests. Consider adding this back or ensuring mock cleanup is handled elsewhere.
import { describe, it, expect, jest } from '@jest/globals';
client/test/unit/model/backend/gitlab/execution/logFetching.test.ts:1
- Removing the null projectId test case reduces coverage for error handling scenarios. This test case helps ensure the function gracefully handles missing project IDs.
import {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@atomicgamedeveloper please add the following lines at the end of |
Contributor
prasadtalasila
left a comment
prasadtalasila
left a comment
There was a problem hiding this comment.
@atomicgamedeveloper thanks for the huge PR. Please see the comments. General suggestions.
- Please remove relative paths in imports.
- Where possible, move code to
model/. For example, new code added inutilcan probably go intomodel/util.
thanks
client/src/database/types.ts
Outdated
| /** | ||
| * Represents the schema for the IndexedDB database | ||
| */ | ||
| export interface IndexedDBSchema { |
Contributor
There was a problem hiding this comment.
this does not seem to have been used anywhere.
Contributor
Author
There was a problem hiding this comment.
I just deleted it. I hope that is fine.
Contributor
9 tasks
…e SonarCube fixes
…tory.slice, executionHistoryDB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Title
Finalize Implementation of Concurrent Digital Twin Execution with IndexedDB Integration
Type of Change
Description
This PR finalizes the implementation of the concurrent execution for Digital Twins with IndexedDB integration. Users can now start multiple executions of the same Digital Twin simultaneously, with execution history persisted in the browser's IndexedDB. The implementation includes a new execution history data model, IndexedDB service, and UI components to display and manage execution history.
New is that it merges recent changes of the up-coming version 0.8 of DTaaS such as settings menu and new interface design.
Working on Testing
Impact
Additional Information
This PR builds on top of #1235 by Microchesst.
Checklist