V3 Identity Map test #106
Open
V3 Identity Map test #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulme
force-pushed
the
aul-UID2-4666-v3-identity-map-e2e-test
branch
from
b38eca3 to
548b1e6
Compare
aulme
force-pushed
the
aul-UID2-4666-v3-identity-map-e2e-test
branch
from
548b1e6 to
a829112
Compare
gmsdelmundo
reviewed
Jun 18, 2025
|
|
||
| // Need to use the manual mapping for error cases - SDK won't allow creating input with bad emails | ||
| public JsonNode v3IdentityMap(String payload) throws Exception { | ||
| V2Envelope envelope = v2CreateEnvelope(payload, getClientApiSecret()); |
There was a problem hiding this comment.
I think we can get rid of all the getClientApiKey() or getClientApiSecret() calls and use the consts directly
| return; | ||
| } | ||
|
|
||
| // We need all properties to be there for Identity Map V3, so default all to empty |
There was a problem hiding this comment.
We don't need all properties to be present
|
|
||
| // Previous UID is there for 90 days after rotation only, then it's null. | ||
| // If it's there, it should have the correct size | ||
| assertThat(mappedDii.getPreviousRawUid()).satisfiesAnyOf( |
There was a problem hiding this comment.
We don't want to do an assertion based on the dii's last updated?
|
|
||
| // Sanity check that refresh from is a date not too far in the past. | ||
| // If it is, either there is an Operator issue or salt rotation hasn't been running for a long time. | ||
| assertThat(mappedDii.getRefreshFrom()).isAfter(Instant.now().minus(Duration.ofDays(10))); |
There was a problem hiding this comment.
Do we want to let the test pass if refresh from is in the past at all?
| "suite.operator.TestData#identityMapV3BatchBadEmailArgs", | ||
| "suite.operator.TestData#identityMapV3BatchBadPhoneArgs" | ||
| }) | ||
| public void testV3IdentityMapUnmapped(String label, Operator operator, String operatorName, String payload, String section) throws Exception { |
There was a problem hiding this comment.
Maybe rename section to identityType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.