fix: FIT-250: SplitChannel audio with spectrogram displaying blank space on waveform #7820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yyassi-heartex
approved these changes
Jun 23, 2025
|
/fm sync |
|
/fm sync |
bmartel
added a commit
that referenced
this pull request
Jun 24, 2025
…ace on waveform (#7820) Co-authored-by: bmartel <bmartel@users.noreply.github.com>
bmartel
added a commit
that referenced
this pull request
Jun 24, 2025
…ace on waveform (#7820) Co-authored-by: bmartel <bmartel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
This pull request includes changes to streamline the handling of waveform height in the
WaveformRendererandVisualizerclasses by removing redundant calculations and ensuring consistent property usage. The key updates focus on simplifying the logic for waveform height and aligning property names for clarity.Waveform height calculation improvements:
WaveformRenderer.ts: Removed the division ofwaveHeightby the number of audio channels (channelCount) in two methods (renderWaveand another unnamed method), simplifying the height calculation to usewaveHeightdirectly. [1] [2]Visualizer.ts: Updated the spectrogram height calculation to directly usewaveHeightand adjusted logic to handle split channels consistently.Property name alignment:
Visualizer.ts: Renamed the propertywaveHeighttowaveformHeightin the configuration object to improve clarity and consistency.