Skip to content

fix: FIT-258: Data Manager tabs created by other users change position after tab order change by the Owner #7819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

yyassi-heartex
Copy link
Contributor

This pull request updates the create method in label_studio/data_manager/serializers.py to improve the handling of the order field when creating a new view. Instead of defaulting to 0, the order field is now dynamically set based on the current count of views within the specified project.

after fix:
image

Enhancements to order field handling:

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner June 23, 2025 20:29
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit cfaf135
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/685aababfd90ac00087d57cd

Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit cfaf135
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/685aabab7ce45f0008a6ef63

Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit cfaf135
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/685aabab88d1950008940ccf

@github-actions github-actions bot added the fix label Jun 23, 2025
@yyassi-heartex yyassi-heartex requested a review from a team June 23, 2025 20:29
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit cfaf135
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/685aababf61b6c0008f8aa2e

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (63e6938) to head (cfaf135).
Report is 6 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7819      +/-   ##
===========================================
- Coverage    78.48%   78.47%   -0.02%     
===========================================
  Files          206      206              
  Lines        16504    16505       +1     
===========================================
- Hits         12953    12952       -1     
- Misses        3551     3553       +2     
Flag Coverage Δ
pytests 78.47% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 24, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/globe.svg

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 24, 2025

/git merge

Workflow run
Successfully merged: 2 files changed, 5 insertions(+), 6 deletions(-)

@robot-ci-heartex robot-ci-heartex merged commit 629af7f into develop Jun 24, 2025
52 of 53 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-258/tab-order-on-create branch June 24, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants