fix: FIT-255: Video settings on Labeling Interface Settings modal don't work #7816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyassi-heartex
requested review from
hlomzik,
Gondragos and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hlomzik
approved these changes
Jun 23, 2025
yyassi-heartex
added a commit
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two changes to the
SettingsModelinweb/libs/editor/src/stores/SettingsStore.js. These changes enhance the model's functionality by adding a new property and a method for toggling boolean properties.before:
after:
Enhancements to
SettingsModel:videoDrawOutside, to theSettingsModel. This property can be used to control whether video elements are drawn outside a specific boundary.toggleProperty(name), which allows toggling the value of a boolean property dynamically. This simplifies the process of flipping boolean states in the model.