fix: BROS-109: Import Dropzone content area moved beyond fold if JSON preview is too large #7805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview is too large
…, as well as to set the header and content elements flush with the card's border.
…he fold. Improves style of code block.
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the import dropzone content was pushed off-screen due to a large JSON preview by refactoring the SimpleCard and CodeBlock components and updating the associated styles and layout.
- Updated SimpleCard to include flushContent and flushHeader props for flexible spacing.
- Modified CodeBlock to accept an optional className for better styling control.
- Adjusted Import.scss and Import.jsx to constrain JSON preview height and ensure dropzone content visibility.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/libs/ui/src/lib/simple-card/index.tsx | Added flushContent, flushHeader, headerClassName, and contentClassName props for spacing control. |
| web/libs/ui/src/lib/code-block/code-block.tsx | Enabled dynamic className support and updated styling classes. |
| web/apps/labelstudio/src/pages/CreateProject/Import/Import.scss | Introduced custom scrollbar mixin and updated height constraints for JSON preview. |
| web/apps/labelstudio/src/pages/CreateProject/Import/Import.jsx | Adjusted SimpleCard usage and CodeBlock container styling to improve layout. |
web/apps/labelstudio/src/pages/CreateProject/Import/Import.scss
Outdated
Show resolved
Hide resolved
|
/fm sync |
…-moved-beyond-fold-if-json-preview-too-large' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15786970999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
The content of the import dropzone area was moving off-screen when the JSON preview was too large, hindering user experience. This change ensures that the import dropzone content remains visible regardless of the JSON preview's size.
Screenshots
Before
After
Testing
The following tests were performed to verify the changes:
Reviewer notes
CodeBlockandSimpleCardcomponent improvements (e.g.,classNameprop, flush props) function as intended and provide the expected styling flexibility.