Skip to content

fix: BROS-128: Fix large data multichannel displaying #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Jun 20, 2025

This pull request fixes the handling of a large amount of data by TimeSeriesVisualizer.

Previously the same logic existed in the ChannelD3. And it was transferred to the new component with some changes for providing supporting MultiChannel mode of displaying. However, there were inaccuracies during the transfer and here are the fixes.

Before

image image

After

image image

@Gondragos Gondragos requested a review from a team as a code owner June 20, 2025 12:46
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 0aa2655
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6855725f1d897000086a9eb2
😎 Deploy Preview https://deploy-preview-7800--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 0aa2655
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/6855725f6ab17100087e7797
😎 Deploy Preview https://deploy-preview-7800--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 0aa2655
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/685572605e37da0008fa3335
😎 Deploy Preview https://deploy-preview-7800--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Jun 20, 2025
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 0aa2655
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/685572606ab17100087e779b
😎 Deploy Preview https://deploy-preview-7800--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cloudmark
Copy link
Contributor

cloudmark commented Jun 20, 2025

Hey @Gondragos tested your changes and this fixes the timeline issue I identified as well.

with this we can also close off this

#7789

and you can close my PR here (because your fix is better because it keeps your optimisations)

#7790

Great stuff 🥳

@cloudmark
Copy link
Contributor

Hey @Gondragos ! I found an issue with the y-axis scaling when fixedscale="false". The y-axis wasn't properly adjusting to the visible data range when zooming - it would show the full dataset range (e.g., -3.0 to 3.0) instead of dynamically scaling to the zoomed section, making the data appear compressed.

Root cause: renderYAxis() was being called before setRangeWithScaling(), so the axis was rendered with the initial domain instead of the calculated domain for the visible range.

Fixed by:

  • Reordering the rendering calls so y-axis renders after domain calculations
  • Improving the dynamic scaling logic with better bounds checking and null value handling
  • Removing redundant axis rendering calls

The y-axis now properly scales to show tight ranges around visible data when zooming with fixedscale="false".

You can cherry pick my commit

fb-BROS-128/ts-mc-uod...cloudmark:label-studio:fb-BROS-128/ts-mc-uod

or I can open a PR which goes to your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants