feat: ROOT-45: Filter by annotator prototype #7783
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This reverts commit 21be28f.
matt-bernstein
force-pushed
the
fb-ROOT-45
branch
from
688b46d to
035677f
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #7783 +/- ##
===========================================
- Coverage 78.56% 78.51% -0.06%
===========================================
Files 206 206
Lines 16478 16516 +38
===========================================
+ Hits 12946 12967 +21
- Misses 3532 3549 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/fmt |
| related_name='children', | ||
| null=True, | ||
| blank=True, | ||
| db_index=False, |
There was a problem hiding this comment.
Is this to satisfy the linter? While it's strictly necessary, I always like to have indices on FKs to support flexible querying
There was a problem hiding this comment.
Yep - I tried adding an index in a concurrent migration, but wasn't able to do it in a way that passed the migration linter
There was a problem hiding this comment.
It's fine to suppress the migration linter like so:
- the index operation will be fast because this is a new column where all the new values will be NULL
| _('index'), | ||
| null=True, | ||
| blank=True, | ||
| default=None, |
There was a problem hiding this comment.
nit - as long as we are making other changes, we can remove this
| default=None, |
| ) | ||
|
|
||
| # `index` is now only meaningful for **root** filters (parent is NULL) | ||
| index = models.IntegerField( |
There was a problem hiding this comment.
is there a way we could name this field to make it clearer what it really represents? display_index or display_order_index would both help in this regard, imo
There was a problem hiding this comment.
This field isn't new, renaming it would have increased change surface area, but yes it's possible. Could do it in a separate chore PR
Allow joining filters into a filterline