Skip to content

feat: ROOT-48: Allow DM results filtering in self serve #7777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

feat: ROOT-48: Allow DM results filtering in self serve #7777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions web/libs/datamanager/src/stores/Tabs/tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ import { TabSelectedItems } from "./tab_selected_items";
import { History } from "../../utils/history";
import { CustomJSON, StringOrNumberID, ThresholdType } from "../types";
import { clamp } from "../../utils/helpers";
import { FF_ANNOTATION_RESULTS_FILTERING, FF_SELF_SERVE, isFF } from "../../utils/feature-flags";
import { FF_ANNOTATION_RESULTS_FILTERING, isFF } from "../../utils/feature-flags";

const THRESHOLD_MIN = 0;
const THRESHOLD_MIN_DIFF = 0.001;
const isSelfServe = isFF(FF_SELF_SERVE) && window.APP_SETTINGS.billing?.enterprise === false;

export const Tab = types
.model("View", {
Expand Down Expand Up @@ -111,7 +110,7 @@ export const Tab = types
},

get currentFilters() {
if (isFF(FF_ANNOTATION_RESULTS_FILTERING) && !isSelfServe) {
if (isFF(FF_ANNOTATION_RESULTS_FILTERING)) {
return self.filters.filter((f) => f.target === self.target);
}
return self.filters.filter((f) => f.target === self.target && !f.field.isAnnotationResultsFilterColumn);
Expand Down
Loading