-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: FIT-173: Follow up fix: Spectrogram initial render #7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bmartel
merged 4 commits into
HumanSignal:develop
from
cloudmark:fix/7761-spectrogram-initial-render
Jun 18, 2025
Merged
fix: FIT-173: Follow up fix: Spectrogram initial render #7762
bmartel
merged 4 commits into
HumanSignal:develop
from
cloudmark:fix/7761-spectrogram-initial-render
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface the spectrogram does not appear (unless we scroll or zoom), we need to defer the draw by a bit when we initialise.
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
makseq
approved these changes
Jun 14, 2025
bmartel
reviewed
Jun 16, 2025
Tested it out and this does not work @bmartel , we need the timeout to defer a bit later, best to keep my changes for consistency |
This reverts commit c10fb6d.
…am-initial-render
bmartel
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Spectrogram Initialization Issue
Reason for Change
Currently, the spectrogram visualization does not appear immediately upon initialization unless there is user interaction (scrolling or zooming). This is a visual bug that affects the user experience as the spectrogram data is loaded but not rendered until interaction occurs.
Solution
We've implemented a deferred draw mechanism that triggers the initial render of the spectrogram shortly after initialization. This ensures the spectrogram is visible immediately without requiring user interaction.
Technical Details
Testing
Visual Evidence
Risks
Rollout Strategy
Reviewer Notes
Related Issue
#7761
General Notes
This fix improves the user experience by ensuring the spectrogram is visible immediately upon initialization, making the visualization more intuitive and reducing potential user confusion about whether the data has loaded correctly.